Fixed subscriptions and announcements not being blockable #4748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mm2PL
changed the title
Felanbird
reviewed
Aug 4, 2023
Co-authored-by: Felanbird <41973452+Felanbird@users.noreply.github.com>
pajlada
approved these changes
Aug 5, 2023
Nerixyz
pushed a commit
to Nerixyz/chatterino2
that referenced
this pull request
Aug 12, 2023
…#4748) * Check blocks for usernotices * changelog * cstd = {.name="C++20"} * Update CHANGELOG.md Co-authored-by: Felanbird <41973452+Felanbird@users.noreply.github.com> --------- Co-authored-by: pajlada <rasmus.karlsson@pajlada.com> Co-authored-by: Felanbird <41973452+Felanbird@users.noreply.github.com>
Nerixyz
pushed a commit
to Nerixyz/chatterino2
that referenced
this pull request
Aug 19, 2023
…#4748) * Check blocks for usernotices * changelog * cstd = {.name="C++20"} * Update CHANGELOG.md Co-authored-by: Felanbird <41973452+Felanbird@users.noreply.github.com> --------- Co-authored-by: pajlada <rasmus.karlsson@pajlada.com> Co-authored-by: Felanbird <41973452+Felanbird@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a previously missing check for blocked users and blocked phrases in USERNOTICEs, both in the recent messages copy (
parseUserNoticeMessage) and the normal one (handleUserNoticeMessage). Deduplicating the code was out of scope for this PR.Closes #3412